Make background steams build-optional

clementine-player · Nov 28, 2021 · 49ce0c6 · 49ce0c6
1 parent bbc5f94
commit 49ce0c6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/ui/backgroundstreamssettingspage.cpp b/src/ui/backgroundstreamssettingspage.cpp
@@ -27,19 +27,24 @@
 
 BackgroundStreamsSettingsPage::BackgroundStreamsSettingsPage(
     SettingsDialog* dialog)
-    : SettingsPage(dialog), ui_(new Ui_BackgroundStreamsSettingsPage) {
+    : SettingsPage(dialog),
+      ui_(new Ui_BackgroundStreamsSettingsPage),
+      loaded_(false) {
   ui_->setupUi(this);
   setWindowIcon(
       IconLoader::Load("weather-showers-scattered", IconLoader::Base));
-
-  for (const QString& name : dialog->background_streams()->streams()) {
-    AddStream(name);
-  }
 }
 
 BackgroundStreamsSettingsPage::~BackgroundStreamsSettingsPage() { delete ui_; }
 
-void BackgroundStreamsSettingsPage::Load() {}
+void BackgroundStreamsSettingsPage::Load() {
+  if (!loaded_ and dialog()->background_streams()) {
+    for (const QString& name : dialog()->background_streams()->streams()) {
+      AddStream(name);
+    }
+    loaded_ = true;
+  }
+}
 
 void BackgroundStreamsSettingsPage::Save() {
   dialog()->background_streams()->SaveStreams();

diff --git a/src/ui/backgroundstreamssettingspage.h b/src/ui/backgroundstreamssettingspage.h
@@ -41,6 +41,7 @@ class BackgroundStreamsSettingsPage : public SettingsPage {
 
  private:
   Ui_BackgroundStreamsSettingsPage* ui_;
+  bool loaded_;
 };
 
 #endif  // BACKGROUNDSTREAMSSETTINGSPAGE_H