Add hooks to xcb_send_request and friends #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Mostly gets ruffle hooking correctly, however, there seems to be some invalid free crash in xlib code, not setting GameInfo::XCBEVENTS avoids this for some reason :/
XCB event objects are expected to be allocated by malloc (not new!), and the caller is supposed to free them (which might not work for new!). xcb_ge_generic_event_t events have variable length, so simply copying the first 36 bytes is not enough. This primarily shows issues with Xlib and Xcb being used together.
This was kind of a TODO, to try to implement the reply side of these hooks, however it turns out to be really tricky, the only sensible thing seems to be to stache the sequence numbers returned then override replies using those sequence numbers. very annoying to do anyways, and it's not needed for now for Ruffle, so not bothering.
CasualPokePlayer
force-pushed
the
xcb_req_hooks
branch
from
90be696 to
3a37c92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly gets ruffle hooking correctly, however, there seems to be some invalid free crash in xlib code, not setting GameInfo::XCBEVENTS avoids this for some reason :/this has been fixed, everything should work correctly.Resolves #593 (for now)