Empty config list should hide corresponding config column #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test the PR we need to either set n_objects or n_agents to 0 right ? When I tried to do so, I still get this error : $ python3 scripts/run_server.py --n_objects 0
Traceback (most recent call last):
File "/home/flowers/Desktop/research_engineer/vivarium/scripts/run_server.py", line 66, in <module>
state = set_state_from_config_dict({StateType.AGENT: agent_configs,
File "/home/flowers/Desktop/research_engineer/vivarium/vivarium/controllers/converters.py", line 223, in set_state_from_config_dict
params = configs[0].param_names()
IndexError: list index out of range |
… into martial/hide_configs_if_empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As @clement-moulin-frier asked, I made so that empty configs should not break the interface.
Related Issue (if applicable)
#53
How to Test
Launch the server
Launch the Panel interface
No changes should be visible for now