-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collisions as part of the simulator state and change default values #46
Changes from 8 commits
e6245a6
0a4ac8f
cf3499c
3118563
11dfee3
3cb5ba3
8a2a48b
4281977
0f2d67f
aad46f9
1a94cc3
9567e57
35b0c29
c2266a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -83,6 +83,8 @@ class SimulatorConfig(Config): | |
neighbor_radius = param.Number(100., bounds=(0, None)) | ||
to_jit = param.Boolean(True) | ||
use_fori_loop = param.Boolean(False) | ||
col_eps = param.Number(0.003) | ||
col_alpha = param.Number(0.7) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These names are not very informative. They might actually be misleading because we already use "col" as a shortcut for column in some files. I would suggest "collision_*" instead (in general better to favor clarity than concision for variable name). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes I thought about it, the "collision_*" syntax will be more informative |
||
|
||
def __init__(self, **params): | ||
super().__init__(**params) | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can discuss this yes, my impression is that this could be done in the context of #30 , so you could move this comment there (and remove it from this file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed I forgot to remove these comments