Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the entire end to end test suite in integration test #114

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

qtomlinson
Copy link
Collaborator

Run definition tests in integration testing on the custom infra structure.
Also add the option of skipping harvest for static components as the harvest can take quite some time.

Run definition tests in integration testing on the custom infra structure.
@qtomlinson qtomlinson marked this pull request as ready for review November 20, 2024 23:41
The timeout value is also used to control the interval between tests.  This adjustment allows for longer rests between tests.
Copy link
Contributor

@ljones140 ljones140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great, I just have a quick question about the npm run changes

id: verify-service-functions
continue-on-error: true
run: DEV_API_BASE_URL=${{ env.DEV_API_BASE_URL }} DYNAMIC_COORDINATES=${{ matrix.dynamicCoordinates }} npm run e2e-test-service
run: DEV_API_BASE_URL=${{ env.DEV_API_BASE_URL }} DYNAMIC_COORDINATES=${{ matrix.dynamicCoordinates }} npm run e2e-test-definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why has this changed from e2e-test-service to e2e-test-definition

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relates to a previous conversation.

@qtomlinson qtomlinson merged commit 144da92 into clearlydefined:main Nov 26, 2024
2 checks passed
@qtomlinson qtomlinson deleted the qt/fix_service_test branch November 26, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants