kernel: Create tool to check for new LTS kernel releases #253

erick0z · 2018-01-20T02:11:47Z

We need to be notified when new LTS kernel releases are available to ensure we
update the guest kernel in a timely fashion.
This commit adds documentation and a script which can check the latest kernel info
and notify via email if a new LTS version is released.

Fixes #246

Signed-off-by: Erick Cardona [email protected]

jodh-intel

Thanks - This is going to be very useful! A few comments...

jodh-intel · 2018-01-22T09:15:29Z

scripts/kernel_monitor/kernel_monitor.py

@@ -0,0 +1,101 @@
+#!/usr/bin/env python3
+#
+# Copyright (c) 2017 Intel Corporation


jodh-intel · 2018-01-22T09:16:42Z

scripts/kernel_monitor/kernel_monitor.py

+email_recipients="root@localhost"
+
+def get_current_lts():
+    lts_file=script_path + "/current_lts_kernel"


I'd be tempted to put the current LTS version in ../versions.txt so that all versions are kept in one place.

jodh-intel · 2018-01-22T09:18:48Z

scripts/kernel_monitor/kernel_monitor.py

+    logging.info("current_lts_kernel file updated!")
+
+def send_email(new_lts):
+    email_body="A new LTS version of the Linux kernel is out: " + new_lts


I'd include the current LTS kernel version too as that will allow us to have an extra "visual check" (hopefully we'll notice the "impossible scenario" where current == new for example).

jodh-intel · 2018-01-22T09:20:07Z

scripts/README.md

+Requirements:
+
+* python3
+* python dependencies (see requirements file)


Could you add a link to this file?

jodh-intel · 2018-01-22T09:20:46Z

scripts/README.md

+
+## `kernel_monitor/kernel_monitor.py`
+
+This script fetch the latest kernel information and look for new LTS releases.


This script fetches the latest kernel information and looks for new LTS releases.

jodh-intel · 2018-01-22T09:21:34Z

scripts/README.md

+## `kernel_monitor/kernel_monitor.py`
+
+This script fetch the latest kernel information and look for new LTS releases.
+If a new LTS release is found, this script is able to send email to the selected


I'd make this even simpler. Something like,

If it finds a new LTS release it sends an email to the selected recipients.

jodh-intel · 2018-01-22T09:22:23Z

scripts/README.md

+$ pip install -r requirements
+```
+
+Set distro_certs variable to /etc/ssl/certs/ca-bundle.crt:


Could you add backticks around that path: /etc/ssl/certs/ca-bundle.crt.

jodh-intel · 2018-01-22T09:23:04Z

scripts/kernel_monitor/kernel_monitor.py

+# email config
+smtp_hostname='127.0.0.1'
+email_sender="[email protected]"
+email_recipients="root@localhost"


How about making these command-line options?

jodh-intel · 2018-01-22T09:23:42Z

scripts/kernel_monitor/kernel_monitor.py

+distro_certs = "/etc/ssl/certs/ca-bundle.crt"
+
+# Log file path
+logfile="./example.log"


This could be a command-line option. Also, I'd change the default to something like kernel_monitor.log.

jodh-intel · 2018-01-22T09:26:05Z

@klynnrif - could you take a look at the doc changes please?

klynnrif

I've suggested a few changes, and agree with the rewrites @jodh-intel made on lines 47 and 48. Thanks!

klynnrif · 2018-01-22T17:16:13Z

scripts/README.md

+
+Usage:
+
+NOTE: Supposing we have a Fedora 27 system with all requirements met and a postfix


Lines 60-61 suggested rewrite: NOTE: The following commands can be executed if you have a Fedora 27 system that meets all requirements, and a postfix server running on 127.0.0.1 or localhost.

klynnrif · 2018-01-22T17:22:21Z

scripts/README.md

+
+Set distro_certs variable to /etc/ssl/certs/ca-bundle.crt:
+
+NOTE: This path may change based on the Linux distribution you are using (see kernel_monitor.py).


NOTE: This path might change based on...

klynnrif · 2018-01-22T17:22:55Z

scripts/README.md

+sed -i "s/distro_certs = .*/distro_certs = \"\/etc\/ssl\/certs\/ca-bundle.crt\"/" kernel_monitor.py
+```
+
+Execute the script:


Execute the following script:

klynnrif · 2018-01-22T17:24:13Z

scripts/README.md

+$ ./kernel_monitor.py
+```
+
+This will send an email to `root@localhost` if there is a new LTS release and log


This sends an email to...

erick0z · 2018-01-22T21:07:42Z

@jodh-intel @klynnrif Thank you! I've addressed your comments.

jodh-intel · 2018-01-23T07:50:12Z

scripts/README.md

+For more information about the complete usage:
+```
+$ ./kernel_monitor.py --help
+Linux Kernel LTS monitor script.


I would recommend removing the output of this command here - one day, the options will change and we'll forget to update the doc as well as the usage statement in the script itself.

jodh-intel · 2018-01-23T07:52:47Z

scripts/README.md

+
+NOTE: This path might change based on the Linux distribution you are using (see kernel_monitor.py).
+```
+sed -i "s/distro_certs = .*/distro_certs = \"\/etc\/ssl\/certs\/ca-bundle.crt\"/" kernel_monitor.py


Couple of points:

This line would need a $ prompt.

I'm really not sure we want users to modify the script itself. Could you add an option for specifying the path to the certs file to avoid this?

jodh-intel · 2018-01-23T07:54:20Z

scripts/README.md

+$ ./kernel_monitor.py
+```
+
+This sends an email to `root@localhost` if there is a new LTS release and log


I'd remove root@localhost and the logfile name here (which I think is now incorrect?) and explain that running, ./kernel_monitor.py --help will show where the emails will be sent and which logfile will be used.

jodh-intel · 2018-01-23T07:54:45Z

scripts/kernel_monitor/kernel_monitor.py

+# by the distro of your choice. This is needed to retrieve the xml file.
+# Fedora => /etc/ssl/certs/ca-bundle.crt
+# Ubuntu => /etc/ssl/certs/ca-certificates.crt
+distro_certs = "/etc/ssl/certs/ca-bundle.crt"


This won't work for Clear Linux.

I think we need a CLI option to specify this path (or have it auto-detected based on distro?)

erick0z · 2018-01-26T20:45:33Z

Hey @jodh-intel, I've now added a distro-certificates discovery functionality (good idea!). It works on Clear Linux as well 😄

jodh-intel · 2018-01-29T08:46:14Z

Hi @erick0z - nice.

For total paranoia, it would probably be safer to only check known locations for each distro (and ensure the file is owned by root:root and not writable). However, I think the current approach is sufficient given that it simply returns a version and we then separately attempt to download that version from a known site using curl (which already knows where to find the correct certs).

lgtm

@klynnrif - could you re-review please?

klynnrif

One small change suggested unless it changes the meaning. Thanks!

klynnrif · 2018-01-30T17:19:15Z

scripts/README.md

+$ ./kernel_monitor.py
+```
+
+This sends an email if there is a new LTS release and log the events to a file.


.....is a new LTS release and logs the events to a file.

We need to be notified when new LTS kernel releases are available to ensure we update the guest kernel in a timely fashion. This commit adds a documentation and a script which can check the latest kernel info and notify via email if a new LTS version is released. Fixes #246 Signed-off-by: Erick Cardona <[email protected]>

erick0z · 2018-01-30T20:04:48Z

thanks! @klynnrif

erick0z added the wip label Jan 20, 2018

jodh-intel reviewed Jan 22, 2018

View reviewed changes

klynnrif suggested changes Jan 22, 2018

View reviewed changes

erick0z removed the wip label Jan 22, 2018

jodh-intel reviewed Jan 23, 2018

View reviewed changes

jodh-intel approved these changes Jan 29, 2018

View reviewed changes

klynnrif suggested changes Jan 30, 2018

View reviewed changes

jodh-intel merged commit e5d4a22 into clearcontainers:master Jan 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kernel: Create tool to check for new LTS kernel releases #253

kernel: Create tool to check for new LTS kernel releases #253

erick0z commented Jan 20, 2018

jodh-intel left a comment

jodh-intel Jan 22, 2018

jodh-intel Jan 22, 2018

jodh-intel Jan 22, 2018

jodh-intel Jan 22, 2018

jodh-intel Jan 22, 2018

jodh-intel Jan 22, 2018

jodh-intel Jan 22, 2018

jodh-intel Jan 22, 2018

jodh-intel Jan 22, 2018

jodh-intel commented Jan 22, 2018

klynnrif left a comment

klynnrif Jan 22, 2018

klynnrif Jan 22, 2018

klynnrif Jan 22, 2018

klynnrif Jan 22, 2018

erick0z commented Jan 22, 2018

jodh-intel Jan 23, 2018

jodh-intel Jan 23, 2018

jodh-intel Jan 23, 2018

jodh-intel Jan 23, 2018

erick0z commented Jan 26, 2018

jodh-intel commented Jan 29, 2018

klynnrif left a comment

klynnrif Jan 30, 2018

erick0z commented Jan 30, 2018


		## `kernel_monitor/kernel_monitor.py`

		This script fetch the latest kernel information and look for new LTS releases.


		Usage:

		NOTE: Supposing we have a Fedora 27 system with all requirements met and a postfix


		Set distro_certs variable to /etc/ssl/certs/ca-bundle.crt:

		NOTE: This path may change based on the Linux distribution you are using (see kernel_monitor.py).

kernel: Create tool to check for new LTS kernel releases #253

kernel: Create tool to check for new LTS kernel releases #253

Conversation

erick0z commented Jan 20, 2018

jodh-intel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jodh-intel commented Jan 22, 2018

klynnrif left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erick0z commented Jan 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erick0z commented Jan 26, 2018

jodh-intel commented Jan 29, 2018

klynnrif left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erick0z commented Jan 30, 2018