This repository has been archived by the owner on May 6, 2020. It is now read-only.
image: Increase image size. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodh-intel
reviewed
Sep 25, 2017
| @@ -51,7 +51,7 @@ exit 1 | |||
| # Image file to be created: | |||
| IMAGE="container.img" | |||
| # Image contents source folder | |||
| IMG_SIZE=${IMG_SIZE:-50M} | |||
| IMG_SIZE=${IMG_SIZE:-80M} | |||
There was a problem hiding this comment.
The README.md still mentions 50M as the default so can you add an update for that too? It might be an idea to add a make settings rule or something to avoid having to update the docs every time we tweak this? That way, we can document, "run make settings to see what settings will be used to create the rootfs/image".
There was a problem hiding this comment.
I like the idea!, working on it.
There was a problem hiding this comment.
Hi @jodh-intel updated docs, and captured #34
The default image size is very small leting the agent to do some operations in storage. Increase to allow the agent run. Fixes: clearcontainers#27 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas
force-pushed
the
increase-image-size
branch
from
0abd5f9 to
5b3a2ba
Compare
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default image size is very small leting the agent to
do some operations in storage.
Increase to allow the agent run.
Fixes: #27
Signed-off-by: Jose Carlos Venegas Munoz [email protected]