don't throw runtime errors, fixes #16

clayallsopp · Mar 10, 2016 · 7ac5201 · 7ac5201
1 parent 9258283
commit 7ac5201
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/graphqlhub-schemas/package.json b/graphqlhub-schemas/package.json
@@ -1,7 +1,7 @@
 {
   "name": "graphqlhub-schemas",
   "repository": "clayallsopp/graphqlhub",
-  "version": "0.1.0-rc6",
+  "version": "0.1.0-rc7",
   "description": "GraphQL Schemas for REST APIs like Github, Hacker News, Reddit, and Twitter",
   "main": "lib/index.js",
   "files": [

diff --git a/graphqlhub-schemas/src/apis/twitter.js b/graphqlhub-schemas/src/apis/twitter.js
@@ -6,11 +6,19 @@ const {
   TWITTER_CONSUMER_SECRET
 } = process.env;
 
-const Twitter = new Twit({
-  consumer_key        : TWITTER_CONSUMER_KEY,
-  consumer_secret     : TWITTER_CONSUMER_SECRET,
-  app_only_auth       : true
-});
+// Twit throws a runtime error if you try to create a client
+// without API keys, so we do it lazily
+let twitterClient = undefined;
+const getTwitterClient = () => {
+  if (!twitterClient) {
+    twitterClient = new Twit({
+      consumer_key        : TWITTER_CONSUMER_KEY,
+      consumer_secret     : TWITTER_CONSUMER_SECRET,
+      app_only_auth       : true
+    });
+  }
+  return twitterClient;
+};
 
 export const getUser = (identifier, identity) => __getPromise('users/show', { [identifier]: identity });
 export const getTweets = (user_id, count)     => __getPromise('statuses/user_timeline', { user_id, count });
@@ -22,7 +30,7 @@ const __getPromise = (endpoint, parameters, resultPath = null) => {
 
   return new Promise((resolve, reject) => {
 
-    Twitter.get(
+    getTwitterClient().get(
       endpoint,
       parameters,
       (error, result) => {