Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 3D Euler normal Riemann solver to more modern Fortran. #73

Closed
wants to merge 2 commits into from

Conversation

ketch
Copy link
Member

@ketch ketch commented Jun 29, 2014

This is a minor modification of #71. It is a rewrite by @weslowrie of the 3D Euler normal Riemann solver, using more modern Fortran. I modified it as follows:

  • use wave rather than qwave, following convention of all other Clawpack solvers
  • Squash several separate commits into one, to keep history cleaner
  • use 4-space indents, consistent with what all Clawpack code is supposed to use (some other Riemann solvers need to be fixed in this respect)
  • Remove some comments that simply restate code
  • Remove comment styling

@ketch ketch mentioned this pull request Jun 29, 2014
@ahmadia
Copy link
Member

ahmadia commented Jun 29, 2014

+1. @weslowrie - You will probably want to review this.

Also remove unnecessary comments and styling.
@ketch
Copy link
Member Author

ketch commented Jun 29, 2014

I would like to put a 3D Euler test into PyClaw before merging this, so that we can check that it gives the same output as the current routine.

@weslowrie
Copy link
Contributor

Looks good to me. Thanks for your edits.

The sample problems I have done are a 1D shock tube in a 3D domain, and a Sedov blast problem in 3D. Do you want me to add those python scripts to the repo?

@ketch
Copy link
Member Author

ketch commented Jun 30, 2014

@weslowrie Yeah, go ahead and submit a PR with the scripts. I can add a test or two that uses them.

@weslowrie
Copy link
Contributor

@ketch I submitted a PR with the scripts. Hopefully they are useful for setting up tests.
For the Sedov blast problem, it could use some more resolution, but the full 3D problem might get to big for a simple test?

@ketch
Copy link
Member Author

ketch commented Jul 24, 2014

Closed in favor of #75.

@ketch ketch closed this Jul 24, 2014
@ketch ketch deleted the rpn3_euler branch November 5, 2014 12:30
mandli added a commit to mandli/riemann that referenced this pull request Mar 19, 2015
Add function for replacing a rundata data object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants