Skip to content

Commit

Permalink
correct example (jazzband#276)
Browse files Browse the repository at this point in the history
map() is a function in python2, and iterator in python3+;

In any case - map is inefficient compared to either comprehensions (most efficient), or simple loops (close second).
SInce in this case, data.append() returns nothing, use a simple look.
It is clearer, more efficient, and works with both python2 and python3
  • Loading branch information
yarko authored and iurisilvio committed Feb 24, 2017
1 parent 46102d4 commit c5c2dff
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ Tablib is an :ref:`MIT Licensed <mit>` format-agnostic tabular dataset library,
::

>>> data = tablib.Dataset(headers=['First Name', 'Last Name', 'Age'])
>>> map(data.append, [('Kenneth', 'Reitz', 22), ('Bessie', 'Monke', 21)])
>>> for i in [('Kenneth', 'Reitz', 22), ('Bessie', 'Monke', 21)]:
... data.append(i)

>>> print data.json
[{"Last Name": "Reitz", "First Name": "Kenneth", "Age": 22}, {"Last Name": "Monke", "First Name": "Bessie", "Age": 21}]
Expand Down

0 comments on commit c5c2dff

Please sign in to comment.