Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.2, 9.4, and 9.6 #63

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Support GHC 9.2, 9.4, and 9.6 #63

merged 2 commits into from
Feb 19, 2024

Conversation

martijnbastiaan
Copy link
Member

@martijnbastiaan martijnbastiaan commented Feb 15, 2024

@martijnbastiaan martijnbastiaan force-pushed the bump-ghc-dep branch 3 times, most recently from 57c6190 to 93c99cf Compare February 15, 2024 15:20
Base automatically changed from bump-circuit-notation to main February 15, 2024 15:38
@martijnbastiaan martijnbastiaan marked this pull request as ready for review February 15, 2024 15:48
Copy link
Member

@kleinreact kleinreact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The only thing I recommend is also adding an issue for your TODO marks in the source code, so it doesn't get lost in the woods.

@martijnbastiaan
Copy link
Member Author

Yeah, that's a good idea!

@martijnbastiaan martijnbastiaan merged commit eb76cd1 into main Feb 19, 2024
9 checks passed
@martijnbastiaan martijnbastiaan deleted the bump-ghc-dep branch February 19, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants