Introduce Protocols.Df.empty #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simple combinator is useful for tying off unused inputs.
bgamari
force-pushed
the
wip/df-empty
branch
from
9f70d69 to
3bb696e
Compare
|
Can this be implemented generically using Edit: I was actually thinking of https://github.com/cchalmers/circuit-notation/pull/25/files but that is not merged yet. |
martijnbastiaan
approved these changes
Sep 9, 2024
|
(LGTM, also curious about |
|
I will merge this as-is and add a variant which asserts |
|
Follow-up is #111. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combinator is both necessary for completeness and is useful for tying off unused inputs.