Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitHub releases page no longer support after parameter, use tags page #480

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

pdecat
Copy link
Member

@pdecat pdecat commented Mar 7, 2025

This PR reverts the previous hotfix from october which did not work properly for releases not containing the version name in the release notes body.

Turns out the after parameter is working on the tags page.

  • Revert "fix: GitHub release page no longer support after parameter"
  • fix: GitHub releases page no longer support after parameter, use tags page

@pdecat pdecat changed the title fix/github releases search fix: GitHub releases page no longer support after parameter, use tags page Mar 7, 2025
@pdecat pdecat requested review from BzSpi, Shr3ps and jmapro March 7, 2025 13:13
@pdecat pdecat force-pushed the fix/github_releases_search branch 2 times, most recently from 7d36203 to fa4b339 Compare March 7, 2025 13:46
Copy link

github-actions bot commented Mar 7, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/claranet_tfwrapper
  __init__.py 593, 598
Project Total  

This report was generated by python-coverage-comment-action

@pdecat pdecat force-pushed the fix/github_releases_search branch from fa4b339 to 6600018 Compare March 7, 2025 14:17
@pdecat pdecat merged commit 2e1f8e2 into master Mar 7, 2025
14 checks passed
@pdecat pdecat deleted the fix/github_releases_search branch March 7, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant