Modernize #32
Modernize #32
Conversation
|
@HighCommander4 would you be willing to review this? |
|
My preference is for changes to a piece of code to be reviewed by the original author of that code, since that person has more familiarity with the code and the reasons it was doing things a certain way. In this case the original author of most of If you don't get a response in a few weeks, please feel free to flag me as a fallback. |
We're formatting TypeScript, not C/C++.
This bumps the version to 0.1.19 because the type of `AbortController`
is not backwards compatible.
- Remove obsolete dependencies.
- abort-controller; `AbortController` is stable since Node 15.4.0.
- source-map-support; `--enable-source-maps` is supported since Node
12.12.0.
- Update dependencies.
- Enable strict mode in `tsconfig.json`.
- Use `which(..., {nothrow: true})` and distinguish between
binary-not-in-PATH and binary-access-failed. Log an error.
- Check for presence of clangd binary in zip archive before extracting.
- Use native promises APIs instead of `promisify`.
- Assign severity to all logs (no more `console.log`).
|
Thank you. In the meantime, could you hit the CI once more? I've replaced |
|
@HighCommander4 could you take a look at this please? It has been 2 weeks now. |
|
@HighCommander4 3 more weeks elapsed. Could you please give this a review? |
|
@tamird I'm sorry, I'm a volunteer contributor and I have limited free time to contribute to clangd. I get a higher volume of review requests than I'm able to keep up with. I will try to get to this, but I can't promise any particular time frame. |
This bumps the version to 0.1.19 because the type of
AbortControlleris not backwards compatible.
AbortControlleris stable since Node 15.4.0.--enable-source-mapsis supported since Node12.12.0.
tsconfig.json.which(..., {nothrow: true})and distinguish betweenbinary-not-in-PATH and binary-access-failed. Log an error.
promisify.console.log).The debugging changes here are what motivated the work; I'm having some problems using vscode-clangd on a remote machine where the path to clangd is absolute, and the current implementation doesn't log anything actionable.