Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repleace unzipper with adm-zip #25

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

fannheyward
Copy link
Member

unzipper is brokwn with Node v18.16 ZJONSSON/node-unzipper#271

closes clangd/coc-clangd#577

src/index.ts Outdated Show resolved Hide resolved
@HighCommander4
Copy link
Contributor

I guess vscode-clangd is not affected by this (yet), because vscode uses electron 25.8 (just recently bumped from 22.x in fact), which uses node 18.15.

Copy link
Contributor

@HighCommander4 HighCommander4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing!

@HighCommander4 HighCommander4 merged commit b4abe89 into master Sep 25, 2023
2 checks passed
dankeboy36 pushed a commit to dankeboy36/install-from-gh-to-vscode that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

could not create connection to server
2 participants