Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake in spec file #300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

NeilHanlon
Copy link
Contributor

@NeilHanlon NeilHanlon commented Jul 5, 2022

  • Fix for running on python3 and building on EL8 or higher
  • replace 'or' keyword with proper '||'

@NeilHanlon NeilHanlon marked this pull request as ready for review July 8, 2022 16:48
@NeilHanlon NeilHanlon changed the title DRAFT: Fix mistake in spec file and fix for RHEL-8/9 useuefi Fix mistake in spec file and fix for RHEL-8/9 useuefi Jul 8, 2022
@NeilHanlon
Copy link
Contributor Author

Hi @nullr0ute - sorry to bother.

One of these changes is to fix a breakage in the spec by my last PR - apologies for that.

I'm happy to split this into multiple PRs if you'd prefer. I did test this on multiple OS types and can confirm the change from self.config.useuefi to self.useuefi in the Guest class does not appear to affect how the Fedora subclass is passing it in. Additionally, it lets RHEL 8 and 9 guests boot with UEFI on x86 without passing in a FedoraConfig class.

Best,
Neil

@nullr0ute
Copy link
Collaborator

I'm glad you tested it this time. For reference we've been using this prior to it for some time on Fedora without issues with py3 etc.

@tobias-urdin
Copy link

Instead of commit e227813 please do like this #304 - that way useuefi can be overriden from config file instead of having to modify get_class() core components or all distro classes.

@NeilHanlon
Copy link
Contributor Author

@tobias-urdin Great idea. Mine was a hacky fix without reading too much of the code base. I've dropped that commit in favor of your #304.

This can probably be merged as well as yours. I've tested it in my setup and it works as expected.

Thank you!

@NeilHanlon NeilHanlon changed the title Fix mistake in spec file and fix for RHEL-8/9 useuefi Fix mistake in spec file Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants