Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore skipComments option on reinitialization of the data process… #17894

Open
wants to merge 2 commits into
base: ck/epic/email-editing
Choose a base branch
from

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Feb 7, 2025

Suggested merge commit message (convention)

Fix (html-support): Comments are no longer lost when FullPage plugin is added after the HtmlComment plugin.


Additional information

The HtmlComment plugin sets skipComments to false but FullPage reinitializes the processor and resets this flag.

Reported in this comment

Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach would not be safe in the future if we added more options. I'd move the editor.data.processor assigned to the plugin constructor the same as in the GFMD plugin so other features can set options on a single data processor instance later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants