Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email integration package #17849

Open
wants to merge 92 commits into
base: master-it84
Choose a base branch
from
Open

Email integration package #17849

wants to merge 92 commits into from

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Jan 30, 2025

Suggested merge commit message (convention)

Feature (email): Initialize email integration package.

Additional Information

Epic branch, do not merge.
Commercial PR: https://github.com/cksource/ckeditor5-commercial/pull/7064

@Mati365 Mati365 force-pushed the ck/epic/email-editing branch from ef17f86 to 6dd2c46 Compare January 31, 2025 15:08
packages/ckeditor5-email/docs/features/email.md Outdated Show resolved Hide resolved
packages/ckeditor5-email/docs/features/email.md Outdated Show resolved Hide resolved
packages/ckeditor5-email/docs/features/email.md Outdated Show resolved Hide resolved
packages/ckeditor5-email/src/emailintegrationutils.ts Outdated Show resolved Hide resolved
packages/ckeditor5-email/src/emailintegrationutils.ts Outdated Show resolved Hide resolved
packages/ckeditor5-email/src/emailintegrationutils.ts Outdated Show resolved Hide resolved
packages/ckeditor5-email/src/integrations/emptyblock.ts Outdated Show resolved Hide resolved
@@ -26,6 +26,7 @@
"@ckeditor/ckeditor5-table": "44.1.0",
"@ckeditor/ckeditor5-utils": "44.1.0",
"@ckeditor/ckeditor5-widget": "44.1.0",
"@ckeditor/ckeditor5-email": "0.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remember to update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick code scan.

package.json Show resolved Hide resolved
Copy link
Contributor

@mmotyczynska mmotyczynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round. No tests checked yet.

packages/ckeditor5-email/package.json Outdated Show resolved Hide resolved
packages/ckeditor5-email/src/emailintegrationconfig.ts Outdated Show resolved Hide resolved
packages/ckeditor5-email/src/emailintegrationutils.ts Outdated Show resolved Hide resolved
packages/ckeditor5-email/src/emailintegrationutils.ts Outdated Show resolved Hide resolved
@Mati365
Copy link
Member Author

Mati365 commented Feb 7, 2025

@pszczesniak

What do you think about showing warning when Markdown plugin is on?

Added in e69a4eb

@godai78 godai78 requested a review from mmotyczynska February 7, 2025 06:53
Mati365 and others added 10 commits February 7, 2025 10:38
#17894)

Fix (html-support): Comments are no longer lost when FullPage plugin is added after the HtmlComment plugin.
…ned-properly-in-output

Fix (table): Plain table should be properly aligned in the output. Closes #17888.
…-from-head-using-fullpage-plugin

Feature(html-support): Introducing the ability to render `<style>` elements from the `<head>` section of editor data content using `FullPage` plugin. See #13482.
@Mati365 Mati365 changed the base branch from master to master-it84 February 11, 2025 14:13
@@ -50,8 +50,6 @@ export default class FullPage extends Plugin {
* it is strongly recommended to define a sanitize function that will clean up the CSS
* which is present in the `<head>` in editors content in order to avoid XSS vulnerability.
*
* For a detailed overview, check the {@glink TODO} documentation.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: Revert it after fixing docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants