-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email integration package #17849
base: master-it84
Are you sure you want to change the base?
Email integration package #17849
Conversation
ef17f86
to
6dd2c46
Compare
@@ -26,6 +26,7 @@ | |||
"@ckeditor/ckeditor5-table": "44.1.0", | |||
"@ckeditor/ckeditor5-utils": "44.1.0", | |||
"@ckeditor/ckeditor5-widget": "44.1.0", | |||
"@ckeditor/ckeditor5-email": "0.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remember to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick code scan.
packages/ckeditor5-html-support/src/integrations/emailintegration.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round. No tests checked yet.
Co-authored-by: Marta Motyczynska <[email protected]>
Co-authored-by: Marta Motyczynska <[email protected]>
Co-authored-by: Marta Motyczynska <[email protected]>
Added in e69a4eb |
#17894) Fix (html-support): Comments are no longer lost when FullPage plugin is added after the HtmlComment plugin.
…nt-from-head-using-fullpage-plugin.
…ned-properly-in-output Fix (table): Plain table should be properly aligned in the output. Closes #17888.
…-from-head-using-fullpage-plugin Feature(html-support): Introducing the ability to render `<style>` elements from the `<head>` section of editor data content using `FullPage` plugin. See #13482.
… make it stateless.
…ssor-fix Internal(full-page): Removed property from the HtmlPageDataProcessor to make it stateless.
…-from-head-using-fullpage-plugin-docs Docs(full-page): Extended guide to `Full page HTML` with a configuration section.
@@ -50,8 +50,6 @@ export default class FullPage extends Plugin { | |||
* it is strongly recommended to define a sanitize function that will clean up the CSS | |||
* which is present in the `<head>` in editors content in order to avoid XSS vulnerability. | |||
* | |||
* For a detailed overview, check the {@glink TODO} documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: Revert it after fixing docs
…f-full-page-html-plugin Docs(full-page): Fixed error code in `Full page HTML` feature.
Suggested merge commit message (convention)
Feature (email): Initialize email integration package.
Additional Information
Epic branch, do not merge.
Commercial PR: https://github.com/cksource/ckeditor5-commercial/pull/7064