Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourceEditorId property to clipboard input events. #17707

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Jan 2, 2025

Suggested merge commit message (convention)

Feature (clipboard): Add ability to detect paste events originating from editor. Closes #15935


Additional information

The main use case is we need to track if the user has pasted content from outside the editor so we can decide if the content needs to be modified before it’s added into CKEditor. See more #15935 (comment)

@Mati365 Mati365 requested review from niegowski and arkflpc January 2, 2025 13:56
@Mati365 Mati365 marked this pull request as draft January 7, 2025 09:41
@Mati365
Copy link
Member Author

Mati365 commented Jan 7, 2025

Solution needs to be changed, as it'll be better to make it more unified with drag & drop which uses mimetypes.

@Mati365 Mati365 changed the title Add isExternal flag to clipboard input events. Add sourceEditorId property to clipboard input events. Jan 7, 2025
@Mati365 Mati365 marked this pull request as ready for review January 7, 2025 11:46
@Mati365
Copy link
Member Author

Mati365 commented Jan 7, 2025

@niegowski I applied suggestion, mime type is now used to determine source editor.

@arkflpc arkflpc requested review from mmotyczynska and removed request for niegowski January 21, 2025 10:01
@Mati365 Mati365 requested a review from gorzelinski January 21, 2025 10:04
@Mati365 Mati365 requested a review from mmotyczynska January 22, 2025 14:41
@Mati365 Mati365 merged commit 0eeccbe into master Jan 22, 2025
9 checks passed
@Mati365 Mati365 deleted the ck/15935 branch January 22, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom property for the content copied from the editor in the clipboard pipeline
3 participants