hgroup and summary should work with source editing #16962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
reviewed
Aug 22, 2024
| allowIn: 'htmlDetails', | ||
| isLimit: true, |
There was a problem hiding this comment.
Indeed, this is could be redundant, I was followed the community PR here
There was a problem hiding this comment.
I added it because I found that, without it, CK would remove the summary element if it contained a heading. If it works without it, great.
jwylarsen
reviewed
Aug 23, 2024
| @@ -341,7 +349,10 @@ export default { | |||
| model: 'htmlHgroup', | |||
| view: 'hgroup', | |||
| modelSchema: { | |||
| allowIn: '$root', | |||
There was a problem hiding this comment.
Why $root and not $container? hgroup can go anywhere
There was a problem hiding this comment.
I think it would be safe to use $container here.
jwylarsen
approved these changes
Aug 26, 2024
… and in $container.
niegowski
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (html-support):
hgroupandsummaryelements should work with source editing. Closes #16947 .Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.