docs: fixed typo in config-manager doc #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SpectreMercury
changed the title
homura
reviewed
Jan 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #620 +/- ##
===========================================
- Coverage 87.29% 87.28% -0.01%
===========================================
Files 118 118
Lines 23983 23992 +9
Branches 2459 2460 +1
===========================================
+ Hits 20935 20942 +7
- Misses 3003 3005 +2
Partials 45 45 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@homura you can just try by yourself and merge this PR ASAP |
I've corrected my suggestion again |
Signed-off-by: homura <[email protected]>
Signed-off-by: homura <[email protected]>
homura
reviewed
Jan 22, 2024
Signed-off-by: homura <[email protected]>
homura
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a typo in the documentation related to an API call in
./lumos/packages/config-manager/README.md, and also corrected the issue with the API reference path. from"@ckb-lumos/config"to"@ckb-lumos/lumos/config"Fixes # (issue)
Type of change
Please delete options that are not relevant.