Pages revisions feature #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amercader
reviewed
Oct 18, 2024
ckanext/pages/theme/templates_main/ckanext_pages/blog_revisions_preview.html
Outdated
Show resolved
Hide resolved
ckanext/pages/theme/templates_main/ckanext_pages/page_revisions_preview.html
Outdated
Show resolved
Hide resolved
|
Hi @amercader , added the mentioned updates and wrote test cases. As for the PR checks, it seems to be failing on 2.9 CKAN, but doesn't look like it is related to my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @amercader and @wardi
With this PR I want to add Revision feature to the Pages and Blog HTML content.
It is a quite straightforward feature that adds and ability to Restore previous Content state in case if something went wrong while saving current version.
By default it creates only 3 versions, while can be increased with ckanext.pages.revisions_limit config setting.
It shouldn't effect old pages that were created before the Revisions logic update and the first Revision for those Pages/Blogs can be create by re-saving the current version.
It required DB upgrade after pulling.
Please review, test this and let me know if any adjustments are needed.