Fix BCP47 check for languages with underscore #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with languages that have "" (enderscore) in the language code. There is no standard for languages with "" and we use initially use check for BCP47 standard (e.g. "-" version).
There were two options:
I choose the first option, as it more appropriate in opinion. The updated version will store the initial behavior, but additionally will check for "" in language code.
You can check this be adding for example "pt_BT" language version to your Dataset schema and while trying to save the form, it will throws an 500 error (this is another issue, but related, because Fluent doesn't find matches for languages with "").