Parse dcat:spatialResolutionInMeters as float #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the spec this should be typed as an xsd:Decimal, but we are parsing it as int: https://www.w3.org/TR/vocab-dcat-3/#Property:dataset_spatial_resolution
seitenbau-govdata
approved these changes
Jun 4, 2024
|
Great! thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec this should be typed as an xsd:Decimal, but we are parsing it as int:
https://www.w3.org/TR/vocab-dcat-3/#Property:dataset_spatial_resolution
WDYT @seitenbau-govdata ?
This allows to retrieve the correct values for decimal numbers (eg
1.5instead of1). This changes slightly the values returned for integers (eg1to1.0) but as this function is only currently used in this property I think it's safe to introduce the change.