Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to decode a string to ASCII explicitly #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

No need to decode a string to ASCII explicitly #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ckanext/archiver/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,16 +650,6 @@ def tidy_url(url):
It may raise LinkInvalidError if the URL has a problem.
'''

# Find out if it has unicode characters, and if it does, quote them
# so we are left with an ascii string
try:
url = url.decode('ascii')
except Exception:
parts = list(urlparse(url))
parts[2] = quote(parts[2].encode('utf-8'))
url = urlunparse(parts)
url = str(url)

# strip whitespace from url
# (browsers appear to do this)
url = url.strip()
Expand Down