Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update header to allow homepage only and add to the login page #71

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

cjrace
Copy link
Owner

@cjrace cjrace commented Jan 5, 2025

Overview of changes

Quick one to add a button to go back to the homepage from the login page as I realised we didn't have one and I got stuck on the login page on our tablet.

Edited the existing header function to add in a homeOnly option that allows for this and added a quick test for it too.

Checklist

  • I have tested these changes locally using pnpm test
  • I have updated the documentation (if needed)
  • I have added or updated tests for these changes (if applicable)

Reviewer instructions

Not a lot to test here, though this is what it looks like (before there was nothing in the top left of the page)

image

@cjrace cjrace added the improvement Enhancement to existing feature label Jan 5, 2025
@cjrace cjrace requested a review from lauraselby January 5, 2025 14:44
@cjrace cjrace merged commit 6f2de58 into main Jan 5, 2025
5 checks passed
@cjrace cjrace deleted the add-home-button-to-login branch January 5, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant