Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update whisky journal rating scale #69

Merged
merged 3 commits into from
Jan 4, 2025

Conversation

cjrace
Copy link
Owner

@cjrace cjrace commented Jan 4, 2025

Overview of changes

  • Updates the whisky rating scale so I split my 4s into two categories.
  • Fixes a typo in the irish bingo page
  • Adds a modal for describing the rating scales to the whisky journal
  • Adds a CSV download option to the whisky journal
  • Added a min width to the search to stop it shrinking too much when heavily zoomed (the CSV button now wraps underneath)

Checklist

  • I have tested these changes locally using pnpm test
  • I have updated the documentation (if needed)
  • I have added or updated tests for these changes (if applicable)

Reviewer instructions

Nothing too specific here.

@cjrace cjrace added the new feature New feature or request label Jan 4, 2025
@cjrace cjrace requested a review from lauraselby January 4, 2025 01:07
@cjrace cjrace marked this pull request as ready for review January 4, 2025 01:11
@cjrace cjrace force-pushed the update-whisky-journal-rating-scale branch from 4891a8c to f9e4cb8 Compare January 4, 2025 18:05
@cjrace cjrace merged commit 1d57d72 into main Jan 4, 2025
5 checks passed
@cjrace cjrace deleted the update-whisky-journal-rating-scale branch January 4, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants