Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate into Opal bootstrap and loader #33

Open
wied03 opened this issue Apr 25, 2016 · 5 comments
Open

Separate into Opal bootstrap and loader #33

wied03 opened this issue Apr 25, 2016 · 5 comments
Assignees

Comments

@wied03
Copy link
Collaborator

wied03 commented Apr 25, 2016

I've been wondering if this loader is really doing 2 things: presenting a "bootstrapped" version of Opal in Node and serving as webpack loader. What if this was split into 2 packages

  1. Opal NPM - could also be called Opal bootstrap. This would include the compiler.rb patches, bundlerCheck/Execute, getRubyMetadata, and the getOpal*Filename.js files

  2. Webpack loader - everything else

This would make it easier to implement #7 because a separate plugin could be developed that could modify webpack's "load path" but take advantage of the Opal NPM code above just like the loader does. No urgency here, but any thoughts @cj ?

@wied03
Copy link
Collaborator Author

wied03 commented Apr 26, 2016

@cj - any opinion on who "owns" the new project (github and NPM) ?

@wied03
Copy link
Collaborator Author

wied03 commented Apr 26, 2016

Also, looks like https://github.com/anthonny/opal-npm-wrapper is out there, although there are some things that would need tweaking with that.

@wied03
Copy link
Collaborator Author

wied03 commented Apr 26, 2016

I might raise an issue and ask how willing they would be to cover the cases the code in the repo does.

@cj
Copy link
Owner

cj commented Apr 26, 2016

any opinion on who "owns" the new project (github and NPM) ?

I don't mind :)

Interesting. Let me know if you get a hold of him. Should we just fork it for now?

@wied03
Copy link
Collaborator Author

wied03 commented Apr 26, 2016

No urgent need for me to do anything, I'm content to wait and see how it plays out personally.

@wied03 wied03 changed the title Separate into Opal bootstrap and loader? Separate into Opal bootstrap and loader Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants