Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similar Projects? #11

Open
wied03 opened this issue Apr 26, 2016 · 7 comments
Open

Similar Projects? #11

wied03 opened this issue Apr 26, 2016 · 7 comments

Comments

@wied03
Copy link

wied03 commented Apr 26, 2016

If you look at cj/opal-webpack#33, we might have similar goals here with the separation we're thinking of making.

That said, we need the following things to make that work:

  1. Opal out of the box - We keep this in here to make it easy to get started. Both of our projects have this. The only difference us we don't check in compiled Opal's into git, we do it as part of the NPM build process
  2. Make bundler/MRI interaction easier - we have this in our code base to make it easier to interoperate with the ruby side of the project, reduce duplication with the Opal GEM itself, and decouple opal-webpack releases from Opal a bit. The part of opal-webpack we've considered separately also easily extracts metadata (in a JSON format) from the MRI side re: Opal GEMS (e.g. opal-jquery, etc.) so it can be used on the webpack side.
  3. Presenting a bootstrap-able compiler (we have this now in our code base, our new "Opal wrapper" would need to support that)

How open would this project be to incorporating 2 and 3 into this project so that we don't have too many opal wrappers flying around on NPM?

@ggrossetie
Copy link
Collaborator

@wied03 To prototype the transpiling of Asciidoctor in JavaScript, I've also created two more repositories 😉
https://github.com/Mogztter/opal-node-runtime
https://github.com/Mogztter/opal-node-compiler

How open would this project be to incorporating 2 and 3 into this project so that we don't have too many opal wrappers flying around on NPM?

I think this is the way to go, we need to merge our projects at some point but we need to make sure that opal-webpack is modular enough because we are not using webpack in Asciidoctor.js

@wied03
Copy link
Author

wied03 commented Apr 26, 2016

@Mogztter - Not intending to merge the webpack side in with this. The idea is to split off the more "opal NPM" components that are webpack agnostic from opal-webpack into a separate project.

@ggrossetie
Copy link
Collaborator

Oh I see!
For example you want to move https://github.com/cj/opal-webpack/blob/master/lib/getCompiler.js into a separate npm component ? Then opal-webpack could rely on this npm component to compile ?

@wied03
Copy link
Author

wied03 commented Apr 26, 2016

Yep, that and some other things

@wied03
Copy link
Author

wied03 commented Apr 26, 2016

Actually that particular file is a little more specific to how we're using the builder with webpack, but I think you get the general idea.

@wied03
Copy link
Author

wied03 commented Apr 29, 2016

If we pulled out the non webpack pieces of our code base, would you guys be open to using that instead of this project? I say that purely based on test coverage, which isn't the only metric, but I just took a quick glance.

@ggrossetie
Copy link
Collaborator

Yes, our need is:

  1. to be able to transpile Asciidoctor to JavaScript using Opal in a npm
    build (Opal compiler)
  2. run asciidoctor.js in a Node environment (Opal runtime)

So as soon as you have a Node package (that does not rely on many
dependencies) to transpile gem and another one (or the same package) to run
Opal, I think we can do the switch and "close" this project.
Le 29 avr. 2016 6:11 PM, "Brady Wied" [email protected] a écrit :

If we pulled out the non webpack pieces of our code base, would you guys
be open to using that instead of this project? I say that purely based on
test coverage, which isn't the only metric, but I just took a quick glance.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#11 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants