Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show search results in context #19

Closed
dcabo opened this issue Oct 3, 2019 · 1 comment
Closed

Show search results in context #19

dcabo opened this issue Oct 3, 2019 · 1 comment
Assignees
Labels

Comments

@dcabo
Copy link
Member

dcabo commented Oct 3, 2019

Either by default or after expanding via a link, it would be useful to show the found sentence surrounded by its context. If we had great blocks (#7) we could just show that, but that's going to take a while and we don't know how good it will be anyway. So we could:

  • Show sentences in the n seconds before/after the results. I think this is a straightforward query in Elastic.

  • Show n sentences before/after. We'd need to add an index to every sentence when loading.

There're subtle differences between the two approaches, but don't know which one is better: if we find the first sentence after a long silence, do we want to show the last sentence from the previous block as context or not? It probably doesn't matter much in practice though.

@dcabo dcabo added the ui label Oct 3, 2019
@dcabo dcabo self-assigned this Oct 7, 2019
@dcabo
Copy link
Member Author

dcabo commented Oct 21, 2019

He hecho esto, que implica hacer cambios en todas las capas: una nueva consulta a Elastic, pasar los datos a Vue, presentarlos. No me he molestado en ponerlo demasiado bonito de momento, pero el resto está.

He aprovechado para ocultar lo del vídeo embebido, que no salta al segundo correcto #27.

@dcabo dcabo closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant