Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import code consolidation, membership import #31943

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 4, 2025

Overview

Import code consolidation, membership import

The code in the Contribution import uses api v4 and uses metadata to separate the values into various entities. The other imports do some of this - with various approaches, using a lot of old code. This updates the Membership import such that when it calls getMappedRow() the values returned are split by entity

Before

getMappedRow() returns an array like

[
  'external_identifier' => '123',
  'membership_type_id' => 'General',
  'join_date' => '2024-07-09',
]

After

getMappedRow() returns an array like

[
  'Contact' => [
    'external_identifier' => '123',
  ],
  'Membership' => [
    'membership_type_id' => 'General',
    'join_date' => '2024-07-09',
  ],
]

Technical Details

Note that by virtue of the only rule being supported being the reserved IndividualSupervisedRule - email is the only additional field supported

Comments

Copy link

civibot bot commented Feb 4, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@eileenmcnaughton eileenmcnaughton changed the title Mapped row 2 Import code consolidation, membership import Feb 4, 2025
@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label Feb 4, 2025
@colemanw
Copy link
Member

colemanw commented Feb 4, 2025

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants