dev/financial#230 - When changing payment method, only make journal entries when financial account changes

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/financial/-/issues/230

Before

Changing payment method works differently than changing financial type when the financial accounts are the same before and after.

After

They work the same.

Technical Details

Currently when you change the financial type on a contribution, it checks to see if the before and after financial account is the same, since then there's no need for a journal entry, since money isn't being moved between accounts. See

civicrm-core/CRM/Contribute/BAO/Contribution.php

Line 3058 in 9e356d4

if ($oldFinancialAccount != $newFinancialAccount) {

But for payment method, it still creates journal entries but just moving money to the same account. This PR makes it check if the account is different first the same as for financial type changes.

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/financial/-/issues/230

[seamuslee001]

@JoeMurray can you confirm this behaviour