Copy Paste Mobile styling CSS for AMD/SMD/Banners Apps in Knack #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following apps I copied the CSS from: - Signs and Markings Operation - Austin Transportation Data Tracker - Street Banners Program Portal I did not modify the code during the copy-paste. There is some discrepancies between Prod (in Knack) and main (in GitHub repo). They are mostly comment/code styling from what I can see and should have no impact as far as I am aware. Differences from the main: - In AMD the spacing of lines on certain code is different in Prod and Main but no function difference - In SMD, BLANK new lines are removed in Prod compared to Main. No functional difference. - In Street Banners Portal, the comments are tagged in /* */ in Prod while Main it is ////. No functional difference. All mobile styling CSS is already included in the copy/paste.
susannegov
requested review from
patrickm02L,
dianamartin,
ChristinaTremel,
ChrispinP and
KaroEngstrom
susannegov
added
documentation
22 tasks
susannegov
changed the title
ChrispinP
approved these changes
Jan 31, 2025
| overflow: auto; | ||
| overflow-wrap: | ||
| break-word; |
There was a problem hiding this comment.
this break-word property value should be moved up after overflow-wrap:
There was a problem hiding this comment.
Not a huge fan of the indent spacing being removed from code inside curly braces, it helps keep track of structure. If its not too much of a hassle, code inside curly spaces should be indented like most other code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this Issue cityofaustin/atd-data-tech#20770
The following apps I copied the CSS from
I did not modify the code during the copy-paste. There is some discrepancies between Prod (in Knack) and Main (in GitHub repo). They are mostly comment/code styling from what I can see and should have no impact as far as I am aware.
Differences between Prod (Knack) and Main (GitHub)
/* */in Prod while Main it is////. No functional difference.All mobile styling CSS is already included in the copy/paste.