Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Model.limit(n).delete_all generates incorrect query #200

Merged
merged 2 commits into from
Dec 4, 2023

Users/amit909sin/issue 195 (#219)

60bfde1
Select commit
Loading
Failed to load commit list.
Merged

Fixes Model.limit(n).delete_all generates incorrect query #200

Users/amit909sin/issue 195 (#219)
60bfde1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 3, 2023 in 1s

84.04% (+0.73%) compared to d91e62c

View this Pull Request on Codecov

84.04% (+0.73%) compared to d91e62c

Details

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d91e62c) 83.31% compared to head (60bfde1) 84.04%.

Files Patch % Lines
lib/activerecord-multi-tenant/delete_operations.rb 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   83.31%   84.04%   +0.73%     
==========================================
  Files          15       16       +1     
  Lines         725      746      +21     
==========================================
+ Hits          604      627      +23     
+ Misses        121      119       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.