-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Camel JBang plugins support #1304
Add Camel JBang plugins support #1304
Conversation
@christophd This is still very much WIP, but I would like some review on the way I parse my actions in YAML 🙏 . |
ab7de2f
to
b1978b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far 👍 many thanks!
e0d4385
to
0f435cd
Compare
ea7f67c
to
e480455
Compare
@christophd This is ready for review on my side. I plan to make a follow up PR with documentation and unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some nitpicks
...oints/citrus-camel/src/main/java/org/citrusframework/camel/actions/AddCamelPluginAction.java
Outdated
Show resolved
Hide resolved
endpoints/citrus-camel/src/main/java/org/citrusframework/camel/actions/CamelPluginAction.java
Show resolved
Hide resolved
...me/citrus-xml/src/main/resources/org/citrusframework/schema/xml/testcase/citrus-testcase.xsd
Outdated
Show resolved
Hide resolved
2fe4b86
to
830e75f
Compare
Would you like me to squash my commits or is it ok like that ? |
yes, please squash would be good, thx |
830e75f
to
22d3056
Compare
* Add camel jbang plugin configuration action * Add camel jbang plugin kubernetes actions: run, verify and delete * Support XML and Yaml
22d3056
to
66fa6ca
Compare
Add camel jbang plugin support with the following features:
TODO in a follow up PR:
Future improuvments:
args
can be used for any additional parameters)