Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Camel JBang plugins support #1304

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented Jan 23, 2025

Add camel jbang plugin support with the following features:

  • [DONE] plugin add: to ensure the installation of the plugin to camel jbang
  • [DONE] plugin kubernetes run: run a camel project kubernetes/openshift ready
  • [DONE] plugin kubernetes verify: check the camel route log
  • [DONE] plugin kubernetes delete: remove the project from kubernetes/openshift platform

TODO in a follow up PR:

  • Add documentation
  • Add Unit Test with mocks

Future improuvments:

  • Add missing parameters (for now args can be used for any additional parameters)
  • Manage integration source code inside the yaml/xml

@gansheer
Copy link
Contributor Author

@christophd This is still very much WIP, but I would like some review on the way I parse my actions in YAML 🙏 .

@gansheer gansheer force-pushed the issues/1280-camel-jbang-plugin-kubernetes-support branch from ab7de2f to b1978b9 Compare January 24, 2025 11:19
Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍 many thanks!

@gansheer gansheer force-pushed the issues/1280-camel-jbang-plugin-kubernetes-support branch 8 times, most recently from e0d4385 to 0f435cd Compare January 31, 2025 14:17
@gansheer gansheer force-pushed the issues/1280-camel-jbang-plugin-kubernetes-support branch 4 times, most recently from ea7f67c to e480455 Compare February 4, 2025 09:12
@gansheer
Copy link
Contributor Author

gansheer commented Feb 4, 2025

@christophd This is ready for review on my side.
I tested the code manually with these citrus case files : gansheer/camel-jbang-plugin-kubernetes-tests#3

I plan to make a follow up PR with documentation and unit tests

@gansheer gansheer marked this pull request as ready for review February 4, 2025 15:25
Copy link
Member

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some nitpicks

@gansheer gansheer force-pushed the issues/1280-camel-jbang-plugin-kubernetes-support branch from 2fe4b86 to 830e75f Compare February 6, 2025 10:41
@gansheer
Copy link
Contributor Author

gansheer commented Feb 6, 2025

Would you like me to squash my commits or is it ok like that ?

@christophd
Copy link
Member

Would you like me to squash my commits or is it ok like that ?

yes, please squash would be good, thx

@gansheer gansheer force-pushed the issues/1280-camel-jbang-plugin-kubernetes-support branch from 830e75f to 22d3056 Compare February 6, 2025 11:55
* Add camel jbang plugin configuration action
* Add camel jbang plugin kubernetes actions: run, verify and delete
* Support XML and Yaml
@gansheer gansheer force-pushed the issues/1280-camel-jbang-plugin-kubernetes-support branch from 22d3056 to 66fa6ca Compare February 7, 2025 15:16
@gansheer gansheer requested a review from christophd February 10, 2025 09:27
@christophd christophd merged commit 8b9a476 into citrusframework:main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants