Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(1290): Fix flaky Kubernetes actor tests #1291

Merged
merged 1 commit into from
Jan 8, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

@Test(singleThreaded = true)
public class KubernetesActorTest {

private final KubernetesMockServer k8sServer = new KubernetesMockServer(new Context(), new MockWebServer(),
Expand All @@ -47,9 +48,9 @@ public void stop() {
k8sServer.destroy();
}

@Test
public void shouldVerifyConnectedState() {
try {
KubernetesActor.resetConnectionState();
Assert.assertFalse(new KubernetesActor(k8sClient).isDisabled());
} finally {
KubernetesActor.resetConnectionState();
Expand All @@ -63,14 +64,15 @@ public void shouldVerifyConnectedState() {
}
}

@Test
public void shouldOverruleConnectedState() {
boolean initial = KubernetesSettings.isEnabled();
try {
KubernetesActor.resetConnectionState();
System.setProperty("citrus.kubernetes.enabled", "false");
Assert.assertTrue(new KubernetesActor(k8sClient).isDisabled());
} finally {
System.setProperty("citrus.kubernetes.enabled", Boolean.toString(initial));
KubernetesActor.resetConnectionState();
}

initial = Boolean.parseBoolean(System.getProperty("citrus.test.actor.k8s.enabled", "true"));
Expand All @@ -79,6 +81,7 @@ public void shouldOverruleConnectedState() {
Assert.assertTrue(new KubernetesActor(k8sClient).isDisabled());
} finally {
System.setProperty("citrus.test.actor.k8s.enabled", Boolean.toString(initial));
KubernetesActor.resetConnectionState();
}
}
}
Loading