kafka concurrent access #1282
Merged
kafka concurrent access #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
force-pushed
the
fix/#1281-kafka-concurrent-access
branch
from
5c41054 to
1c3db3d
Compare
bbortt
requested review from
tschlat and
christophd
and removed request for
tschlat
ah yea, that makes sense 💃🏼 my clicking is way too fast for GitHub. |
bbortt
force-pushed
the
fix/#1281-kafka-concurrent-access
branch
from
1c3db3d to
de66a59
Compare
bbortt
added
State: Review
bbortt
force-pushed
the
fix/#1281-kafka-concurrent-access
branch
from
de66a59 to
bf69def
Compare
tschlat
requested changes
Jan 6, 2025
endpoints/citrus-kafka/src/main/java/org/citrusframework/kafka/endpoint/KafkaConsumer.java
Outdated
Show resolved
Hide resolved
endpoints/citrus-kafka/src/main/java/org/citrusframework/kafka/endpoint/KafkaConsumer.java
Outdated
Show resolved
Hide resolved
endpoints/citrus-kafka/src/main/java/org/citrusframework/kafka/endpoint/KafkaConsumer.java
Outdated
Show resolved
Hide resolved
endpoints/citrus-kafka/src/main/java/org/citrusframework/kafka/endpoint/KafkaConsumer.java
Outdated
Show resolved
Hide resolved
endpoints/citrus-kafka/src/main/java/org/citrusframework/kafka/endpoint/KafkaConsumer.java
Outdated
Show resolved
Hide resolved
bbortt
force-pushed
the
fix/#1281-kafka-concurrent-access
branch
3 times, most recently
from
39f687b to
aa1566a
Compare
|
@tschlat I've now added a flag |
christophd
approved these changes
Jan 8, 2025
…a consumer added a reproducer for citrusframework#1281. indeed the test which is part of the `KafkaEndpointJavaIT` throws: ```shell java.util.ConcurrentModificationException: KafkaConsumer is not safe for multi-threaded access. currentThread(name: Thread-1, id: 124) otherThread(id: 125) ```
…tion The `org.apache.kafka.clients.consumer.KafkaConsumer<K,V>` is **not thread-safe**. When using selective message consumption, it is recommended to configure `useThreadSafeConsumer` respectively `thread-safe-consumer` for the Kafka endpoint. Otherwise, you will experience errors when executing tests in parallel.
bbortt
force-pushed
the
fix/#1281-kafka-concurrent-access
branch
from
aa1566a to
8744ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1281.