fix(#1100): empty file resource returns true on exist #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
requested changes
Jan 29, 2024
core/citrus-api/src/main/java/org/citrusframework/spi/Resources.java
Outdated
Show resolved
Hide resolved
core/citrus-api/src/test/java/org/citrusframework/spi/ResourcesTest.java
Show resolved
Hide resolved
tschlat
force-pushed
the
issue/1100/empty_file_resoures_exist
branch
from
a8c00c2 to
ee1198d
Compare
bbortt
force-pushed
the
issue/1100/empty_file_resoures_exist
branch
from
ee1198d to
a119504
Compare
well thank you! |
bbortt
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1100:
An UrlResource pointing to an existing but empty file must return true on exist.
Also added a couple of tests.