Update TaskFollowPointRoute.md #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added flags and updated the name of the intunknown
|
RIP - I guess thats a no... 😢 |
|
The last argument should be
|
|
CI failed because you didn't write followpointroutemode in the same way as in the parameters. Anyway, the correct name of this parameter is |
Made requested changes...hope this follows the pattern needed
|
Done - Added changes. please approve for moneys |
AvarianKnight
requested changes
Dec 16, 2023
TASK/TaskFollowPointRoute.md
Outdated
| @@ -5,8 +5,15 @@ ns: TASK | |||
|
|
|||
| ```c | |||
| // 0x595583281858626E 0xB837C816 | |||
| void TASK_FOLLOW_POINT_ROUTE(Ped ped, float speed, int unknown); | |||
| void TASK_FOLLOW_POINT_ROUTE(Ped ped, float speed, int mode); | |||
There was a problem hiding this comment.
routeMode would be a better name
(Hopefully) fixed enum so that it's formatted properly! Used the above example...as an example
Committing to change to the last parameter name pending any additional enum changes needed
Hopefully this is the appropriate change. Still willing to try again if not. Thanks!
AvarianKnight
requested changes
Dec 21, 2023
Clean up old remnants and port over usage example.
AvarianKnight
requested changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this follows the recent advice given, nonetheless, roastme! :D
Added flags and updated the name of the intunknown
Before you submit this PR, please make sure: