Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BeginTextCommandDisplayText.md #907

Closed

Conversation

niekschoemaker
Copy link
Contributor

No description provided.

Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes, thank you for your contribution 🙂

refer to _GET_LABEL_TEXT from BEGINT_TEXT_COMMAND_DISPLAY_TEXT
@AvarianKnight
Copy link
Collaborator

Not sure if you're still interesting in PRing these changes, if you are can you rebase the recent changes to these natives.

HUD/BeginTextCommandDisplayText.md Outdated Show resolved Hide resolved
@AvarianKnight
Copy link
Collaborator

AvarianKnight commented Aug 7, 2024

Didn't realize part of this PR got superseded by #937

If you're interested in continuing this please rebase to the latest commit and fix the conflicts, this file got renamed to GetFilenameForAudioConversation.md

@AvarianKnight AvarianKnight added needs validation This looks good, but needs additional confirmation of suggested change. abandoned Abandoned by Author and removed needs validation This looks good, but needs additional confirmation of suggested change. labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Abandoned by Author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants