Added descriptions for a few camera DoF natives #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JajarGaming
approved these changes
Mar 31, 2023
AvarianKnight
requested changes
Apr 1, 2023
|
Okay should be all fixed |
4mmonium
suggested changes
Jun 16, 2023
4mmonium
reviewed
Jun 16, 2023
4mmonium
reviewed
Jun 16, 2023
|
All done, sorry for the late response |
4mmonium
reviewed
Oct 5, 2023
4mmonium
reviewed
Oct 10, 2023
4mmonium
reviewed
Oct 10, 2023
4mmonium
reviewed
Nov 13, 2023
Improve native example so users can copy it and see what the native does.
Reduce redundancy by referencing examples instead.
Better to not link to URLs that could get lost in the future.
|
I corrected the examples and referenced to other natives to reduce redundancy, LGTM. |
4mmonium
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example usage of the natives that I added a description for: https://forum.cfx.re/t/camera-depth-of-field-settings/2433316/3
Figured out the usages by playing around with said natives and looking at the results.