Add missing argument and improve documentation #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not 100% sure as to what the arguments do exactly because the behavior of the native changes depending on whether oal is enabled or not, not sure what's going on there, I'm assuming this is due to the missing argument. Without OAL it always does the non flashing fade in, and with OAL it always does the flashing fade in, even though this is not the actual missing argument.
|
I've validated that the argument is indeed missing from decompiled scripts, all calls did have 3 arguments and were along the lines of: |
4mmonium
reviewed
Oct 27, 2023
4mmonium
reviewed
Oct 27, 2023
4mmonium
suggested changes
Oct 27, 2023
I've ammended the requested changes to the pull request, wasn't entirely sure which part could be done, but removed any "official" reference to the parameter and added a comment in the example and in the description about the missing parameter. |
4mmonium
reviewed
Nov 27, 2023
4mmonium
suggested changes
Nov 27, 2023
AvarianKnight
added
the
needs validation
AvarianKnight
requested changes
Aug 9, 2024
AvarianKnight
added
ready-to-merge
and removed
needs validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure as to what the arguments do exactly because the behavior of the native changes depending on whether oal is enabled or not, not sure what's going on there, I'm assuming this is due to the missing argument.
Without OAL it always does the non flashing fade in, and with OAL it always does the flashing fade in, even though this is not the actual missing argument.