Updated/fixed 3 exclusive driver related natives #625
Conversation
-Renamed native (removed underscore). -Added matching JOAAT hash. -Fixed parameters -Updated description
Renamed and updated description
|
May need to double check ABI compatibility on In addition, this native has been incorrect for so long, that changing it at this point will likely break scripts that have compensated for this mess. Just something to consider. |
Yeah I added that alias for documentation of prior name purposes but I see the issue now. I've removed that alias now.
How would I do that? The parameter type was previously set as an integer but after looking at the disassembly, it's clearly an int*. I've changed the file to include cs_type int now though.
I guess we could leave the native names set to their incorrect names, but ensure the hashes are correct? The SET_VEHICLE_EXCLUSIVE_DRIVER_2 naming etc was quite confusing. |
|
|
||
| ```c | ||
| // 0xB09D25E77C33EB3F | ||
| BOOL _IS_PED_EXCLUSIVE_DRIVER_OF_VEHICLE(Ped ped, Vehicle vehicle, int outIndex); | ||
| // 0xB09D25E77C33EB3F 0xFF62D324 |
There was a problem hiding this comment.
I'm not sure adding joaat hashes is supported, this might break existing resources.
Where did you get this hash from?
There was a problem hiding this comment.
The joaat hash was taken from the previous VEHICLE/SetVehicleExclusiveDriver.md.
As you can see, the previous joaat hashes didn't match.
If you hash "IS_PED_EXCLUSIVE_DRIVER_OF_VEHICLE" you will get 0xFF62D324.
| --- | ||
| ## SET_VEHICLE_EXCLUSIVE_DRIVER | ||
|
|
||
| ```c | ||
| // 0x41062318F23ED854 0xFF62D324 | ||
| void SET_VEHICLE_EXCLUSIVE_DRIVER(Vehicle vehicle, cs_type(Ped) BOOL toggle); | ||
| // 0xB5C51B5502E85E83 0xAA8BD440 |
There was a problem hiding this comment.
Again, not sure if changing hashes is properly supported.
Maybe @blattersturm could verify this?
stannum-cfx
added
the
needs validation
|
Given the fact that theres no nice way to add this without breaking compatibility with existing resources I'm going to close this. |
No description provided.