correct names and parameter names for air defence natives #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayPaulinCodes
suggested changes
Oct 11, 2024
| int CREATE_AIR_DEFENCE_ANGLED_AREA(float srcCoord1X, float srcCoord1Y, float srcCoord1Z, float srcCoord2X, float srcCoord2Y, float srcCoord2Z, float fWidth, float weaponPositionX, float weaponPositionY, float weaponPositionZ, cs_type(Any) Hash weaponHash); | ||
| ``` | ||
|
|
||
| ## Parameters |
There was a problem hiding this comment.
Please provide the following if possible:
- Parameter descriptions
- Return value description
- Native description
There was a problem hiding this comment.
I don't know how they work which is why the documentation is missing
There was a problem hiding this comment.
Same as #1204 (comment)
WEAPON/CreateAirDefenceSphere.md
Outdated
| * **p4**: X coordinate | ||
| * **p5**: Y coordinate | ||
| * **p6**: Z coordinate | ||
| * **weaponPositionX**: X coordinate |
There was a problem hiding this comment.
Specify the differences between the 2 sets of coords passed to the native. Having just "X coordinate" isn't very helpful as the name tells us that, would be better to be something more like "X coordinate of the weapon position" or whatever is applicable for this case.
There was a problem hiding this comment.
Same here, i've removed the undescriptive "X coordinate" now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.