Update DisableAllControlActions.md #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added enums instead of a hyperlink redirecting to the native ENABLE_ALL_CONTROL_ACTIONS. Added CAMERA_CONTROL enum which was unknown.
colistro123
suggested changes
Aug 24, 2024
There was a problem hiding this comment.
May I suggest leaving this file as-is?
Instead of modifying this file, why not simply update the EnableAllControlActions.md file? While this scenario is unlikely, it is preferable to centralize enums. This way, if updates are needed in the future, they can be made in a single file rather than in multiple locations.
Additionally, changing padIndex to controlType could impact the parameter naming conventions, as most parameters for these kind of natives are currently named padIndex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit this PR, please make sure: