fix(statebag): only try to erase if the key existed before #2937
+15
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we would always check for the
Nil
value at the start of theif
chain we would always send this to the server or client.This changes the behavior to only erase if the key existed in the first place, and if it didn't then we will just do an early return so we don't replicate the data (and possibly hit the rate limiter).
Goal of this PR
Reduce the amount of packets sent to the server whenever the state bag doesn't already exist
How is this PR achieving the goal
Fix the checks to take into account that the key could not exist
This PR applies to the following area(s)
FiveM, RedM, Server
Successfully tested on
Game builds: ..
Platforms: Windows, Linux
Checklist
This hasn't been tested
Fixes issues
Fixes an oversight in PR #2717