fix(ci/windows): Downgrade MSVC build tools #2836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github Actions running on 'windows-latest' get shipped with VS 2022 C++ x64/x86 build tools v14.41-17.11 which includes various breaking changes. This manually downgrades VS build tools to v14.40-17.10 as a temporary fix till the build tool chain is updated.
github-actions
bot
added
the
triage
4 tasks
|
Does that mean we don't need this pull request anymore with #2837? |
Correct, once 2837 got merged this workaround isn't needed anymore. |
|
Ok then this probably can be closed, because merging both at the same time won't be needed. |
|
Superseded by #2837 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Github Actions running on 'windows-latest' get shipped with VS 2022 C++ x64/x86 build tools v14.41-17.11 which includes various breaking changes that make building on the CI pipeline fail.
How is this PR achieving the goal
Github Actions doesn't allow to use older image versions, so we downgrade VS build tools to v14.40-17.10 manually as a temporary fix. This only downgrades necessary components to avoid increasing the build time any further.
This can be reverted once the build tool chain got updated.
This PR applies to the following area(s)
CI, Building
Successfully tested on
Game builds: Not applicable
Platforms: Github Actions - Windows Latest
Checklist
Fixes issues
/