Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vehicle sync tree causing getters to return the wrong values #2834

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

minemalox
Copy link
Contributor

Goal of this PR

  • Fixing getting the wrong values returned when using server getters like GET_VEHICLE_NUMBER_PLATE_TEXT

How is this PR achieving the goal

This PR applies to the following area(s)

  • FiveM, Server

Successfully tested on

  • Couldn't test it myself, but comparing the new and old synctree only showed this difference between them.

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

  • Not working server getters like GET_VEHICLE_NUMBER_PLATE_TEXT

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Oct 3, 2024
@minemalox minemalox changed the title fix: removed second primary color serialization fix: vehicle sync tree returning the wrong values Oct 3, 2024
@minemalox minemalox changed the title fix: vehicle sync tree returning the wrong values fix: vehicle sync tree causing getters to return the wrong values Oct 3, 2024
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Oct 3, 2024
@minemalox minemalox force-pushed the vehicle-sync-tree branch 3 times, most recently from 23c474c to 5a20bc9 Compare October 3, 2024 16:37
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Oct 3, 2024
@ahcenezdh
Copy link
Contributor

Good catch, indeed it was a mistake i didn't see this one

@FabianTerhorst
Copy link
Contributor

Please make sure to only commit the relevant line changes. You made many whitespace changes here that are not relevant for this fix.

@minemalox
Copy link
Contributor Author

Please make sure to only commit the relevant line changes. You made many whitespace changes here that are not relevant for this fix.

Didn't realize yesterday that there were still some whitespace changes, should now be fixed. @FabianTerhorst

Copy link
Contributor

@FabianTerhorst FabianTerhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 👍

@FabianTerhorst FabianTerhorst added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Oct 5, 2024
@prikolium-cfx prikolium-cfx merged commit aaab438 into citizenfx:master Oct 7, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants