Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gameinput): put txAdmin keys mappings at the top #2826

Closed
wants to merge 1 commit into from

Conversation

ahcenezdh
Copy link
Contributor

Goal of this PR

Actually, @tabarra added # in his key mappings to have the txAdmin key mappings at the top of the FiveM key settings. This PR aims to fix this so Tabarra doesn't have to do this workaround

How is this PR achieving the goal

By checking the tag (resourceName) is monitor (txAdmin), if it's the case we are returning true

This PR applies to the following area(s)

FiveM

Successfully tested on

image
Here is a screen where i did the test with a resource called ns_carrierheist

Game builds: 3258

Platforms: Windows,

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Actually, @tabarra added # in his key mappings to have the txAdmin key mappings at the top of the FiveM key settings. This PR aims to fix this so Tabarra doesn't have to do this workaround
@ahcenezdh ahcenezdh closed this Oct 1, 2024
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant