Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(clrcore): add missing LicensePlateStyle enum types #2818

Merged
merged 1 commit into from
Oct 3, 2024
Merged

tweak(clrcore): add missing LicensePlateStyle enum types #2818

merged 1 commit into from
Oct 3, 2024

Conversation

XdGoldenTigerOfficial
Copy link
Contributor

@XdGoldenTigerOfficial XdGoldenTigerOfficial commented Sep 26, 2024 •
edited
Loading

Add new license plate style indexes to LicensePlateStyle enum.
Since they where added to the Native Docs, they should of been added to the C# enum list at the same time.

Goal of this PR

Adding the new license plate styles from the latest DLC

...

This PR applies to the following area(s)

FiveM, ScRT: C#

...

Successfully tested on

Latest

Game builds: Latest

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Sep 26, 2024
@XdGoldenTigerOfficial XdGoldenTigerOfficial marked this pull request as ready for review September 26, 2024 09:38
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Sep 26, 2024
@XdGoldenTigerOfficial XdGoldenTigerOfficial changed the title Update LicensePlateStyle enum to include new license plate styles tweak(clrcore): add missing LicensePlateStyle enum types Sep 26, 2024
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action labels Sep 26, 2024
@FabianTerhorst
Copy link
Contributor

Thanks for your contribution. Please adjust the commit name to the same name you used for the pull request title.

XdGoldenTigerOfficial
XdGoldenTigerOfficial commented Sep 26, 2024
View reviewed changes
Copy link
Contributor Author

@XdGoldenTigerOfficial XdGoldenTigerOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated commit name to tweak(clrcore): add missing LicensePlateStyle enum types

@FabianTerhorst
Copy link
Contributor

Updated commit name to tweak(clrcore): add missing LicensePlateStyle enum types

Good, now you just need to squash the two commits together.

@XdGoldenTigerOfficial
tweak(clrcore): add missing LicensePlateStyle enum types
880fa6f 
Add new license plate style indexes to `LicensePlateStyle` enum.

tweak(clrcore): add missing LicensePlateStyle enum types
@XdGoldenTigerOfficial
Copy link
Contributor Author

Sorry for delay, Squashed the commits

FabianTerhorst
FabianTerhorst approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@FabianTerhorst FabianTerhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, values are looking good.

@FabianTerhorst FabianTerhorst added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 26, 2024
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged ScRT: C# Issues/PRs related to either C# scripting runtimes labels Sep 26, 2024
@XdGoldenTigerOfficial XdGoldenTigerOfficial mentioned this pull request Sep 27, 2024
Closed
@Legacy-TacticalGamingInteractive
Copy link

❤️

@prikolium-cfx prikolium-cfx merged commit 0e6f24d into citizenfx:master Oct 3, 2024
4 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianTerhorst FabianTerhorst FabianTerhorst approved these changes

Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged ready-to-merge This PR is enqueued for merging ScRT: C# Issues/PRs related to either C# scripting runtimes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XdGoldenTigerOfficial @FabianTerhorst @Legacy-TacticalGamingInteractive @prikolium-cfx